python-neo icon indicating copy to clipboard operation
python-neo copied to clipboard

Add NeuronexusRawIO/IO

Open zm711 opened this issue 1 year ago • 5 comments

Fixes #1296.

I'll try to work on this a bit in my free time. Will switch off draft when ready for review.

Also should help for neuroconv

  • [x] Add tests
  • [x] Get file on GIN

zm711 avatar Jul 18 '24 22:07 zm711

No rush on this @apdavison, this is a new io. Since Sam will be going on vacation, I think getting some feedback would be nice, but I can also pester him once he is back. There is no rush on this one :)

zm711 avatar Jul 24 '24 16:07 zm711

To discuss here: expose logical streams instead of buffer streams for this format.

h-mayorquin avatar Aug 23 '24 18:08 h-mayorquin

It would be relatively easy. My only concern is that if we have a universal way to do this then we are adding more work to adapt all of these rawios into the new format. But in this case the last six channels are reserved for the non-ephys data. So I could split these off intro logical streams.

zm711 avatar Aug 23 '24 18:08 zm711

Or we could merge this as is and then iterate for the logical streams in a new PR. That way if the buffer -> stream api happens before we have time then we fold that in and if this becomes an issue for users we can quickly fix it upon request before the api is added.

zm711 avatar Aug 27 '24 12:08 zm711

@samuelgarcia, this one can also take a review in your queue. Just pinging you now that you're back here. We have a couple requests on spikeinterface (and on neuroconv) for this. At your leisure of course.

zm711 avatar Aug 27 '24 12:08 zm711

C'est le ping à Sam de la semaine.

zm711 avatar Sep 16 '24 15:09 zm711

ceci n'est pas une ping

h-mayorquin avatar Sep 16 '24 16:09 h-mayorquin

He's on the thread. He'll see it :P

zm711 avatar Sep 16 '24 16:09 zm711

Salut Zach. This looks good to me. I made one or two comments. Sorry for the long delay.

samuelgarcia avatar Sep 23 '24 14:09 samuelgarcia

Thanks Sam. I think this is ready to go now after your feedback!

zm711 avatar Sep 23 '24 15:09 zm711

merci

samuelgarcia avatar Sep 27 '24 13:09 samuelgarcia