Array-annotate Amplitudes and PCs in PhyIO

Open Kleinjohann opened this issue 3 years ago • 2 comments

PhyIO was written before array_annotations were fully functional, so it had TODOs in the comments to deal with data which should be array_annotated once that's possible. I added array_annotations for PCs and amplitudes to all spikes, and since the PCs can be quite a lot of data I added a flag that can be toggled to load them.

Aug 26 '22 13:08 Kleinjohann

Hi Alexander, This is OK for me. Maybe I would also add an option (false by default) to load or not the amplitudes of spikes like you did for PCs. I guess that amplitudes can be an extra big vector.

Aug 29 '22 12:08 samuelgarcia

Hi Samuel, thanks for having a look! I added a flag for the amplitudes as well.

Aug 29 '22 16:08 Kleinjohann

Hi @Kleinjohann thanks for adding this! The failing test are not related to phy but an instable connection to gin for some other tests.

Oct 06 '22 13:10 JuliaSprenger