python-neo icon indicating copy to clipboard operation
python-neo copied to clipboard

auto push to pypi on push tags

Open samuelgarcia opened this issue 3 years ago • 5 comments

@JuliaSprenger @apdavison @mdenker : have a look. This auto push to pypi when we tag. We have the same on spikeinertface. Here we don't run the full io test which too long. Only the neo.core. I think this is enough.

samuelgarcia avatar Mar 08 '22 15:03 samuelgarcia

This is a definite no for me. We should not make a release until the full test suite passes (including IO) and the docs build correctly.

Also, this PR should target test.pypi.org.

If everything works, then we switch to the real PyPI.

apdavison avatar Mar 08 '22 16:03 apdavison

also, shouldn't this only be for tags that match a specific pattern? tags aren't only used for releases.

apdavison avatar Mar 08 '22 16:03 apdavison

Hi Andrew. Thanks for the feedback.

  1. OK I will integrate the full test suite so with all dependencies.
  2. for teh doc, yes I forgot about it
  3. The test.pypi I never play with this, I don't figure out how to do this. I will investigate.
  4. For the tag pattern, yes we should do that. Any idea ?

samuelgarcia avatar Mar 08 '22 17:03 samuelgarcia

Also we should check that neo/version.py do not contain any '.dev0' as a security.

samuelgarcia avatar Mar 08 '22 17:03 samuelgarcia

@samuelgarcia Any updates on this? Would be nice to use this already for the next release :)

JuliaSprenger avatar Mar 31 '22 11:03 JuliaSprenger

I propose to close and reopen something later

samuelgarcia avatar Apr 03 '23 09:04 samuelgarcia