Ensure attributes & elements can have sinular/plural equivalents generated

[pgleeson]

trafficstars

e.g. see https://github.com/NeuralEnsemble/libNeuroML/blob/development/neuroml/examples/ion_channel_generation.py

Should be doc.ion_channels.append(chan) not doc.ion_channel.append(chan)

[pgleeson]

This is due to this line: https://github.com/NeuralEnsemble/libNeuroML/blob/2e10b9a3e16667c747672fd606d108737bf25a18/neuroml/nml/generateds_config.py#L96

needed to ensure attribute ionChannel in ChannelDensity becomes ion_channel

[vellamike]

Could you explain this issue Padraig? It should either be singular or plural, there shouldn't be the choice. Shouldn't 'ion_channel' just be changed to 'ion_channels' ?

On 21 February 2014 18:10, Padraig Gleeson [email protected] wrote:

This is due to this line:

https://github.com/NeuralEnsemble/libNeuroML/blob/2e10b9a3e16667c747672fd606d108737bf25a18/neuroml/nml/generateds_config.py#L96

needed to ensure attribute ionChannel in ChannelDensity becomes ion_channel

Reply to this email directly or view it on GitHubhttps://github.com/NeuralEnsemble/libNeuroML/issues/46#issuecomment-35756888 .

[sanjayankur31]

I see ion_channel but ion_channel_hhs etc. so I think this is still an issue.

Note: I think making this change will change the signature of the NeuroMLDocument constructor etc., so this will be a backwards incompatible breaking change which will need to be clearly announced with an appropriate version bump + changelog entry etc..