elephant icon indicating copy to clipboard operation
elephant copied to clipboard

[Feature] Online Unitary Event Analysis

Open ojoenlanuca opened this issue 2 years ago • 3 comments

This pull request introduces an online version of the Unitary Event Analysis (UEA). It is related to the pull request #405, because it provides another online batched statistic. These pull requests could be reviewed jointly, but also separately, depending on what will be more efficient in terms of the overall time needed for the reviews.

Like the other online batched measures in #405, the online version of the UEA is implemented as a class, which stores the necessary intermediate results within class-attributes and updates them with the aid of the 'update_uea()' class-method. To perform such an update-step, several helper-methods are used to manage the spike data and to pre-process it in the same manner as the standard/offline UEA it does.

The 'concurrent_test_runner_for_uea.py' module is optional. It executes all test-functions of 'TestOnlineUnitaryEventAnalysis' unittest.TestCase, which is located in 'test_online.py', in a concurrent manner to reduce run-time. It uses the third-party package 'concurrencytest', which is yet not part of the 'elephant'-requirements.

Task List

  • [x] decide whether this pull request will be reviewd jointly or separately from #405
  • [ ] review code, identify weak points and suggest repair work
  • [ ] merge this pull-request

ojoenlanuca avatar Jun 01 '22 13:06 ojoenlanuca

Hello @ojoenlanuca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 205:14: E111 indentation is not a multiple of four Line 205:14: E117 over-indented Line 475:57: E251 unexpected spaces around keyword / parameter equals Line 482:58: E251 unexpected spaces around keyword / parameter equals Line 508:61: E251 unexpected spaces around keyword / parameter equals Line 515:53: E251 unexpected spaces around keyword / parameter equals Line 771:25: E128 continuation line under-indented for visual indent Line 809:31: E127 continuation line over-indented for visual indent

Line 272:46: E251 unexpected spaces around keyword / parameter equals Line 274:46: E251 unexpected spaces around keyword / parameter equals Line 366:46: E251 unexpected spaces around keyword / parameter equals Line 368:46: E251 unexpected spaces around keyword / parameter equals

Comment last updated at 2022-09-06 08:25:11 UTC

pep8speaks avatar Jun 01 '22 14:06 pep8speaks

Hey @ojoenlanuca, I suggest to proceed with this PR in the following way:

  1. review code
  2. create PR on branch INM-6:feature/online_measures (this branch was recently updated to match the current state of elephant), see also PR #405
  3. merge into master

Thanks for contributing !

Moritz-Alexander-Kern avatar Jun 24 '22 11:06 Moritz-Alexander-Kern

Coverage Status

Coverage increased (+0.4%) to 87.66% when pulling 162149ad149a3d28e392893b1a5d1b6465e21bac on INM-6:feature/online_measures_uea into 73e8a5f06f6312a9c8a3889babe2a41cfbd45526 on NeuralEnsemble:master.

coveralls avatar Sep 06 '22 08:09 coveralls