Fritz Lehnert
Fritz Lehnert
From a Google search, it seams that a lot of devices have issues after an update to **Android 12**. It seems that multiple device types are affected. Within https://github.com/julian-klode/dns66/issues/472 there...
This is a possible duplicate of https://github.com/julian-klode/dns66/issues/475.
Should `master` and `v1.X` actually be covered by the same checks or are there differences needed? ~~In case it is the same, why not just extend the branch protection rules...
> And creating a PR would require codeowner reviews again? _No, not necessarily._ It is true, that one (or multiple [or no]) group(s) of people can be freely configured to...
> * triggered comment-pr-on-check-failure.yml is failing iiuc This was addressed with second commit by removing the trigger. > * check if the revert case is covered as in comment-pr-on-check-failure.yml Yes,...
> How was the semantic PR broken? The summary says "The semantic PR workflow is broken in so far as it has some strange interaction with the cloud-workflow", but I...
> Can you link to an example where the semantic PR check failed because of the cloud workflow? [Link](https://tngtech.slack.com/archives/C02H13P7RJN/p1659610351485349) to some random private channel. Some screenshots are:   ...
Rebased on master to resolve conflicts from https://github.com/magma/magma/pull/13696.
:heavy_check_mark: This PR successfully de-coupled the `semantic-pr` and `cloud-workflow`. E.g. see the PR https://github.com/magma/magma/pull/13715 which has a [broken cloud workflow](https://github.com/magma/magma/actions/runs/2933904495), but the [semantic PR is fine](https://github.com/magma/magma/actions/runs/2933904404). (Previously the semantic-pr would...
Closing as per argument in https://github.com/magma/magma/issues/13199#issuecomment-1243723508.