warp icon indicating copy to clipboard operation
warp copied to clipboard

Published 20 hours ago • verified publisher icon NethermindEth

Refactor createLiteralFromType

Open piwonskp opened this issue 2 years ago • 4 comments

The function is located here. The function should call safeGetNodeType function to differentiate nodes instead of using typestring. The value shouldn't be extracted from type but from the node itself.

piwonskp avatar Mar 04 '23 00:03 piwonskp

Would love to pick this up if no one is at it right now!

cwkang1998 avatar Mar 05 '23 16:03 cwkang1998

We'll merge #871 in few days so I suggest waiting until then :) Let me just ask @cicr99, as she has worked on that recently, do you have anything to add to the issue?

piwonskp avatar Mar 05 '23 18:03 piwonskp

I don't have anything to add to this issue

cwkang1998 avatar Mar 06 '23 14:03 cwkang1998

Hey @cwkang1998, we've merged #871 so you can work on it :)

piwonskp avatar Mar 13 '23 20:03 piwonskp