warp icon indicating copy to clipboard operation
warp copied to clipboard

Finish the transition to solc-typed-ast v11.0.2

Open piwonskp opened this issue 2 years ago • 0 comments

The new version of solc-typed-ast introduced a lot of changes. Even though warp updated the package to the newest version it's not been fully ported to it yet. Especially warp is not using InferType class, but an obsolete typestring parser.

To see how many tests are failing when using infertype class uncomment the block of code.

Some changes that are needed to fully port warp to the new version:

  • [ ] Modify nodes each time typestring is modified
  • [ ] Adapt builtins link
  • [ ] Move some transformations to the end of processing (e.g. constants to literals)
  • [ ] #849
  • [ ] Set typename when creating a new node (spotted on VariableDeclaration node)
  • [ ] Remove generateExpressionTypeString or add implementation for new nodes (eg. super, emitting event)
  • [x] Handle warp's custom cairo nodes
  • [ ] Handle function visibility. Eg. use isFunctionCallExternal
  • [ ] Research and fix problems with missing MemberAccess properties (e.g. using_for/library.sol)
  • [ ] #971

piwonskp avatar Jan 09 '23 17:01 piwonskp