warp icon indicating copy to clipboard operation
warp copied to clipboard

Transpile libraries

Open LuisLara-UH opened this issue 3 years ago • 2 comments
trafficstars

The idea here is to clone the ContractDefinition nodes of kind Library, and change its kind to Contract. This way, it does not interfere with the references to the Library node functions, and it transpiles the Library clone as a contract.

LuisLara-UH avatar Sep 12 '22 15:09 LuisLara-UH

Could you add a test?

GuyMcComb avatar Sep 16 '22 09:09 GuyMcComb

I removed the externalize-functions, because this is only for transpile the internal and private functions which aren't referenced by public or external functions. After discussed with Rodrigo, I realized these functions are not necessary for the transpiled library, because they are not reachable.

LuisLara-UH avatar Sep 23 '22 16:09 LuisLara-UH

Are we waiting for a semantic test run or can we merge this?

swapnilraj avatar Sep 30 '22 11:09 swapnilraj