warp icon indicating copy to clipboard operation
warp copied to clipboard

DeclarationNameMangler_audit_fixes

Open AlejandroLabourdette opened this issue 3 years ago • 1 comments

This pull request fix problems pointed by audit for declarationNameMangler.ts:

  • Use a set for reserverdTerms to make queries faster
  • Use Regex to find unsupportedCharacters in terms
  • Use a unified counter to create id's for variable, internal function and new Type names
  • Set a fixed width for id's in variables and internal function names to be able to sort them

Tickets: https://www.notion.so/nethermind/AUDIT-CVF-35-declarationNameMangler-ts-de23ff0e7679484cb4f89ac58e9805aa https://www.notion.so/nethermind/AUDIT-CVF-34-declarationNameMangler-ts-70b3c656cffc42efb6da34dce0e51701 https://www.notion.so/nethermind/AUDIT-CVF-33-declarationNameMangler-ts-1f8d615bac8a4994a0d530b97ec3e4ab https://www.notion.so/nethermind/AUDIT-CVF-32-declarationNameMangler-ts-d69483bfcd5e4f828f1f049257354cc5

  • [x] Sem Tests Running
  • [x] Sem Tests Passed

AlejandroLabourdette avatar Sep 08 '22 18:09 AlejandroLabourdette

Sem Tests Passed

GuyMcComb avatar Sep 14 '22 08:09 GuyMcComb