warp icon indicating copy to clipboard operation
warp copied to clipboard

refac: starknetCli

Open syahirAmali opened this issue 3 years ago • 2 comments

  • refactored existing functions
  • created buildCairoCommand to generate starknet commands
  • created callCairoCommand that executes the execSync
  • broke down functions to be used for testing

syahirAmali avatar Aug 25 '22 03:08 syahirAmali

Just a couple of comments on the test suite made;

  • not entirely sure how to export the commanderjs commands from index.ts to the testing file, so right now, it is simply a duplicate of the command and options
  • console outputs from errors aren't being suppressed during testing so they will still be visible

syahirAmali avatar Aug 30 '22 13:08 syahirAmali

  • Added command program factory for current commands
  • Tests and index.ts now uses the program factory

syahirAmali avatar Sep 09 '22 12:09 syahirAmali

Do not forget to refactor --cairo-compile like it is in the current CLI. Also, do not forget to removed the delcare from deploy, make that optional. Add max_fee

GuyMcComb avatar Oct 07 '22 12:10 GuyMcComb

There have been some significant fixes to the cli in src/index.ts as a result of the Uniswap tests. They'll need to be reflected in this pr.

JorikSchellekens avatar Oct 17 '22 01:10 JorikSchellekens

This looks abandoned so closing it, will re-open if someone wants to continue the work

swapnilraj avatar Oct 26 '22 14:10 swapnilraj