starknet.go icon indicating copy to clipboard operation
starknet.go copied to clipboard

Change FeeEstimation type to use u64 and u128 instead of felt.Felt

Open thiagodeev opened this issue 9 months ago • 9 comments

Spec ref: https://github.com/starkware-libs/starknet-specs/blob/master/api/starknet_api_openrpc.json#L3478

Depends on: https://github.com/NethermindEth/starknet.go/issues/709

thiagodeev avatar Apr 08 '25 13:04 thiagodeev

Hello @thiagodeev I want to help solving this issue if it is possible

danielcdz avatar Apr 09 '25 02:04 danielcdz

Hey @danielcdz! You are welcome to help

thiagodeev avatar Apr 09 '25 02:04 thiagodeev

@thiagodeev thanks! can you provide me any extra context to complete the task, is my first time contributing to this project

danielcdz avatar Apr 09 '25 02:04 danielcdz

You can take a look at the examples folder to learn how to work with the library, especially the invoke example; it shows how to estimate the fee. The goal is to change the FeeEstimation type returned by the EstimateFee method, make it use u64 and u128 values when necessary (this is the spec link describing which fields should be changed)

thiagodeev avatar Apr 09 '25 03:04 thiagodeev

@thiagodeev thanks!

danielcdz avatar Apr 09 '25 04:04 danielcdz

@thiagodeev Hello! I raised a draft PR to track my progress. qq, can we use the rpc.U64 and rpc.u128 types for this?

danielcdz avatar Apr 10 '25 20:04 danielcdz

Hey @danielcdz, thanks again. Our team has decided internally to stop working on this matter. For now, we will let things as they are. In the future, when we implement Cairo types in starknet.go, we'll make this change.

If you can, there's something else we need help: a method for deploying contracts via UDC (https://github.com/NethermindEth/starknet.go/issues/381)

thiagodeev avatar Apr 11 '25 20:04 thiagodeev

@thiagodeev Got it, thanks for the heads-up! I’d be more than happy to help with issue #381. I’ll need a bit of context and guidance to get started, but I’m eager to learn and support the team on this

danielcdz avatar Apr 12 '25 21:04 danielcdz

Depends on https://github.com/NethermindEth/starknet.go/issues/709

thiagodeev avatar Apr 23 '25 20:04 thiagodeev