sedge icon indicating copy to clipboard operation
sedge copied to clipboard

Remove support for Goerli

Open khalifaa55 opened this issue 1 year ago • 1 comments

Changes:

  • Remove support for Goerli from Sedge

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [x] Other (please describe): removing feature

Testing

Requires testing

  • [x] Yes
  • [ ] No

In case you checked yes, did you write tests?

  • [x] Yes
  • [ ] No

Comments about testing , should you have some (optional) adjusted network_test.go : TestNetworkCheck function

khalifaa55 avatar Apr 23 '24 12:04 khalifaa55

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.59%. Comparing base (4d41a7d) to head (5e2d90d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #372   +/-   ##
========================================
  Coverage    86.59%   86.59%           
========================================
  Files           78       78           
  Lines         3977     3977           
========================================
  Hits          3444     3444           
  Misses         448      448           
  Partials        85       85           
Flag Coverage Δ
unittests 86.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 29 '24 19:04 codecov-commenter