nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard
verified publisher icon NethermindEth

More use of ProgressLogger.

Open asdacap opened this issue 9 months ago • 3 comments

  • There is a ProgressLogger class for logging progress.
  • It is quite nice.
  • Some part of the codebase does not use it.
    • Full pruning.
    • VerifyTrie
    • Not sure what else, find it.
  • Make them use it.

asdacap avatar Apr 10 '25 00:04 asdacap

I would like to take this on. Feel free to assign it to me 😄

richardgreg avatar Apr 10 '25 08:04 richardgreg

@asdacap checkout #8509

Vivkzz avatar Apr 10 '25 11:04 Vivkzz

hi @asdacap pls checkout #8541

let me know your feedback

avdheshcharjan avatar Apr 20 '25 09:04 avdheshcharjan

Did this ever get solved or could I get assigned please? @asdacap

Oliverpt-1 avatar Jul 11 '25 13:07 Oliverpt-1

@Oliverpt-1 you can try this if you want. Please keep in mind:

  • Provide some log sample on full pruning.
  • The trie iteration progress cant simply be estimated by the total number of keys in the db. For example, the point of full pruning is to reduce the number of keys in the DB, so its not gonna copy all key.

asdacap avatar Jul 13 '25 03:07 asdacap

@asdacapDoes this issue still open, or did #8520 resolve this?

0xvikram avatar Aug 15 '25 15:08 0xvikram