nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

eth_simulate does not return eth log when selfdestructive contract sends eth

Open OlegJakushkin opened this issue 1 year ago • 0 comments

Fixes nethermind does not return eth log when selfdestructive contract sends eth issue. Expected log was:

"logs": [
    {
        "address": "0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee",
        "topics": [
            "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
            "0x000000000000000000000000c200000000000000000000000000000000000000",
            "0x0000000000000000000000000000000000000000000000000000000000000000"
        ],
        "data": "0x00000000000000000000000000000000000000000000000000000000001e8480",
        "blockNumber": "0x139368a",
        "transactionHash": "0x200fab0bcc81da4a444d4bd94c11132f7343c8ce9f2aa6c30d0844397d28f945",
        "transactionIndex": "0x0",
        "blockHash": "0x6ac1e3302e98cb7d11c007b8ea448c42839b7e095ed28123cab09b267fdb94cb",
        "logIndex": "0x0",
        "removed": false
    }
],

Changes

  • EVM logging callback

Types of changes

What types of changes does your code introduce?

  • [x] Bugfix (a non-breaking change that fixes an issue)
  • [ ] New feature (a non-breaking change that adds functionality)
  • [ ] Breaking change (a change that causes existing functionality not to work as expected)
  • [ ] Optimization
  • [x] Refactoring
  • [ ] Documentation update
  • [ ] Build-related changes
  • [ ] Other: Description

Testing

Requires testing

  • [x] Yes
  • [ ] No

If yes, did you write tests?

  • [x] Yes
  • [ ] No

Requires explanation in Release Notes

  • [ ] Yes
  • [x] No

OlegJakushkin avatar Aug 14 '24 12:08 OlegJakushkin