nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

Override RLP decoders with ones from plugins; fix op decoder

Open flcl42 opened this issue 1 year ago • 1 comments

Changes

  • Register plugin decoders, allowing to override existing ones
  • Add keyed decoders, means in addition to type a string key can be used to retrieve and encoder
  • Fix sync trace logs a bit

Types of changes

What types of changes does your code introduce?

  • [x] Bugfix (a non-breaking change that fixes an issue)
  • [x] New feature (a non-breaking change that adds functionality)
  • [x] Breaking change (a change that causes existing functionality not to work as expected)
  • [ ] Optimization
  • [ ] Refactoring
  • [ ] Documentation update
  • [ ] Build-related changes
  • [ ] Other: Description

Testing

Requires testing

  • [ ] Yes
  • [x] No

If yes, did you write tests?

  • [ ] Yes
  • [x] No

Remarks

We need to do the same for tx receipt storage, I guess. But maybe later

flcl42 avatar May 02 '24 10:05 flcl42

Haha, didn't see was draft :)

benaadams avatar May 02 '24 10:05 benaadams

Would be good to have someone from optimism stack review it too.

It's done according to what a learned from @protolambda's answers

flcl42 avatar May 14 '24 13:05 flcl42