nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

[WIP]Add Eip6110 implementation

Open Demuirgos opened this issue 1 year ago • 1 comments

Fixes Closes Resolves #6274

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

  • implements Eip6110 as per spec : https://eips.ethereum.org/EIPS/eip-6110

Types of changes

What types of changes does your code introduce?

  • [ ] Bugfix (a non-breaking change that fixes an issue)
  • [x] New feature (a non-breaking change that adds functionality)
  • [ ] Breaking change (a change that causes existing functionality not to work as expected)
  • [ ] Optimization
  • [ ] Refactoring
  • [ ] Documentation update
  • [ ] Build-related changes
  • [ ] Other: Description

Testing

Requires testing

  • [x] Yes
  • [ ] No

If yes, did you write tests?

  • [ ] Yes
  • [x] No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • [ ] Yes
  • [x] No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • [x] Yes
  • [ ] No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

Demuirgos avatar Feb 04 '24 23:02 Demuirgos

Need to find a better way to expose Spec.Eip6110ContractAddress to BlockValidator to avoid IReleaseSpec creeping out everywhere

Demuirgos avatar Feb 05 '24 01:02 Demuirgos