nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

[Pruning] Make pruning logs better visible for users when it is in progress

Open kamilchodola opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. Right now log for pruning in Progress looks like this: Full Pruning In Progress: 06:52:03.2701416 889.00 mln nodes mirrored.

Since it is appearing once every 30 seconds and it is an activate which triggers once in few months maybe we should be more verbose about it

Describe the solution you'd like Maybe something like this? To be discussed.

---------------------------------------- (horizontal line)

Full Pruning: 06:52:03 | 889.00 mln nodes mirrored Status: In Progress

---------------------------------------- (horizontal line)

kamilchodola avatar Dec 16 '23 21:12 kamilchodola

Also not sure (need to check) but this info should be in HealthCheck module when pruning is working.

kamilchodola avatar Dec 16 '23 21:12 kamilchodola

doing the pruning for the first time actually, and i got here by searching for explanation what these mln nodes are.

so presumably that is short for million? i'd be happy if this is more verbose. also, why the float? is a partial node possible?

i would really refrain from making logs multiline if not absolutely necessary. it makes dealing with them further down the pipeline a magnitude bigger of a hassle.

also, is there no chance at all to give the current, dynamic target amount? that would at least give a hint on the progress

Full Pruning In Progress: 23:46:53.4209336 1,664.00 mln nodes mirrored.

could be (not sure about the proper punctuation for the number):

Full Pruning In Progress: Passed time: 23:46:53, mirrored nodes: 1.664.000.000, estimated goal: 3.162.000.000

related: #6021

whysthatso avatar May 01 '24 12:05 whysthatso