nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

Published 20 hours ago • verified publisher icon NethermindEth

Support for blockOverride in eth_call, eth_estimateGas, eth_createAccessList

Open MarekM25 opened this issue 1 year ago • 5 comments

We need one more parameter: blockOverride to methods eth_call, eth_estimateGas, eth_createAccessList. https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.cs#L337

This parameter should override values specified here: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Facade/BlockchainBridge.cs#L245 It should override parameters no matter if treatBlockHeaderAsParentBlock is true or false.

Geth has already implemented it, but only for eth_call and it could be treated as a reference. List of parameters that could be overridden can be found here: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.cs#L337

MarekM25 avatar Sep 21 '23 15:09 MarekM25

@MarekM25 I can take a look.

bitcoinbrisbane avatar Sep 21 '23 23:09 bitcoinbrisbane

Sure - @bitcoinbrisbane assigned you

MarekM25 avatar Sep 25 '23 09:09 MarekM25

Sure - @bitcoinbrisbane assigned you

On it.

bitcoinbrisbane avatar Sep 28 '23 01:09 bitcoinbrisbane

For my reference: https://github.com/etclabscore/core-geth/blob/ed7fd700435f8796437a32e61c2550573cc7e9e1/ethclient/gethclient/gethclient.go#L289

bitcoinbrisbane avatar Oct 06 '23 22:10 bitcoinbrisbane

@bitcoinbrisbane are you working on this issue or can I assign it to someone else?

MarekM25 avatar Jan 19 '24 12:01 MarekM25