nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

Refactor `PivotUpdator` to be really infinite

Open marcindsobczak opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. Right now we are using MaxAttemptsToUpdatePivot = int.MaxValue, which is enough, because it means that node is trying to update pivot for ~68 years before giving up. But making it really infinite would be nice.

Describe the solution you'd like Refactor code to make infinite attempts to update pivot if MaxAttemptsToUpdatePivot is e.g. -1

Additional context Automatic pivot updates were introduced here: https://github.com/NethermindEth/nethermind/pull/5256 And changed to "infinite" here: https://github.com/NethermindEth/nethermind/pull/5988

marcindsobczak avatar Aug 09 '23 08:08 marcindsobczak

i want to fix this issue. but when i cloned it started it in docker it was giving me issues. Screenshot 2023-09-14 165821

rupak21 avatar Sep 15 '23 06:09 rupak21

@marcindsobczak we can close, right?

kamilchodola avatar Jan 18 '24 11:01 kamilchodola

I am applying to this issue via OnlyDust platform.

Mitish98 avatar Jun 26 '24 21:06 Mitish98