nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

OnlyStaticPeers should disallow connection from random peers. Move DicoveryEnabled to NetworkConfig. OnlyStaticPeers should implicitly disable Discovery.

Open smartprogrammer93 opened this issue 2 years ago • 5 comments

Description OnlyStaticPeers should disallow connection from random peers. Move DiscoveryEnabled to NetworkConfig. OnlyStaticPeers should implicitly disable Discovery.

Steps to Reproduce In order to replicate the behavior, please provide a detailed list of steps:

  1. Run nethermind with OnlyStaticPeers enabled
  2. Notice how nethermind still connects to non static peers

Actual behavior Connects to non static peers

Expected behavior Should not connect to non static peers

Desktop (please complete the following information): Please provide the following information regarding your setup:

  • Windows
  • 1.20
  • debugging
  • Prysm

smartprogrammer93 avatar Jul 07 '23 11:07 smartprogrammer93

Can i work on this issue?

btme0011 avatar Sep 16 '23 19:09 btme0011

@btme0011 sure

smartprogrammer93 avatar Sep 16 '23 19:09 smartprogrammer93

Hi @smartprogrammer93 is this issue still relevant?

ssonthal avatar Sep 16 '24 16:09 ssonthal

@shubham-sonthalia yeah, would you like to work on it?

smartprogrammer93 avatar Sep 16 '24 16:09 smartprogrammer93

yes sure.

ssonthal avatar Sep 16 '24 16:09 ssonthal

It was adjusted recently by @asdacap and should work fine now - closing. https://github.com/NethermindEth/nethermind/pull/7514

kamilchodola avatar Jan 09 '25 16:01 kamilchodola