nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

Published 20 hours ago • verified publisher icon NethermindEth

Snap is not excluded in discovery

Open MarekM25 opened this issue 2 years ago • 3 comments

MarekM25 avatar Sep 14 '22 09:09 MarekM25

@MarekM25 what is the status of this PR?

dceleda avatar Sep 23 '22 13:09 dceleda

@MarekM25 what is the status of this PR?

I have to add unit tests, deprioritized because it isn't important after the merge or we can merge it as it is now

MarekM25 avatar Sep 26 '22 10:09 MarekM25

@MarekM25 what is the status of this PR?

I have to add unit tests, deprioritized because it isn't important after the merge or we can merge it as it is now

From my experience - add unit tests. Whenever I skip them, I'm bitten later ;)

dceleda avatar Sep 26 '22 10:09 dceleda