nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

Move keys to keyStoreDirectory

Open deffrian opened this issue 2 years ago • 2 comments

Fixes | Closes | Resolves #

Anything marked as optional that you didn't need to fill in, please remove it from the PR description. Choose one of the keywords above to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

  • Now keys located in keystore/Nethermind directory

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

Requires testing

  • [ ] Yes
  • [ x ] No

deffrian avatar Jul 26 '22 15:07 deffrian

Is it backwards compatible?

No, it will generate new keys in keystore directory

deffrian avatar Aug 03 '22 17:08 deffrian

Is it backwards compatible?

No, it will generate new keys in keystore directory

So I guess we can't work in this way

MarekM25 avatar Aug 04 '22 09:08 MarekM25

FTR, i'm bitten by this on Guix, i.e. a non-docker based setup.

attila-lendvai avatar Dec 19 '22 00:12 attila-lendvai

@matilote

tkstanczak avatar Jan 23 '23 14:01 tkstanczak