nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

Fix clique-validators.sh script

Open dapplion opened this issue 3 years ago • 0 comments

Changes:

Script from guide at https://docs.nethermind.io/nethermind/ethereum-client/private-networks/how-to-setup-a-nethermind-only-clique-based-chain#manual-setup does not work

  • goerli.json has a trailing comma that breaks jq
  • re-running the script errors in linux because directories exist
  • TODO: Nodes can't connect to each other

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

Requires testing

  • [x] Yes
  • [ ] No

In case you checked yes, did you write tests??

  • [ ] Yes
  • [x] No

Comments about testing , should you have some (optional)

Must be tested manually, just run the script takes 30 seconds

./clique-validators.sh

dapplion avatar Jun 10 '22 09:06 dapplion