nethermind icon indicating copy to clipboard operation
nethermind copied to clipboard

feat: add CentralPackageVersions management

Open xas opened this issue 2 years ago • 2 comments

Changes:

  • centralize nuget package management (see CentralPackageVersions)
  • add Directory.Build.targets file
  • add Packages.props file
  • !update of all the packages to their latest version

The purpose of this PR is to keep all the projects using the same nuget package version (avoid inconsistency) and be able to globally update a package version without parsing all the projects/solutions

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update
  • [x] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

Requires testing

  • [ ] Yes
  • [x] No

In case you checked yes, did you write tests??

  • [ ] Yes
  • [x] No

Further comments (optional)

As I updated all the nuget packages, maybe some testing are needed to verify new version don't cause any regressions, plus need to check on submodules also

xas avatar Apr 06 '22 07:04 xas

Might be good, but needs thorough review I will take a look after merge is being finalized. Maybe someone else can take a look earlier.

RIder might not support it fully: https://youtrack.jetbrains.com/issue/RIDER-41194 Also: https://www.mytechramblings.com/posts/centrally-manage-nuget-versions/ And also this might be better: https://stu.dev/managing-package-versions-centrally/ which Rider also doesn't support: https://youtrack.jetbrains.com/issue/RIDER-41805

LukaszRozmej avatar Apr 14 '22 11:04 LukaszRozmej

Also: https://www.mytechramblings.com/posts/centrally-manage-nuget-versions/

Yup, I read this one, I thought the nuget solution was the good one, but as the team define the functionality as still in preview, I've gone for the simpler one, and the migration seems easy (only need to rename Packages.props to Directory.Packages.props , or I missed a part ?)

xas avatar Apr 15 '22 08:04 xas

With the release of .NET 7, we can move to the central package management once the project initial migration is done and dusted.

rubo avatar Nov 09 '22 11:11 rubo

With the release of .NET 7, we can move to the central package management once the project initial migration is done and dusted.

Feel free to do that :)

LukaszRozmej avatar Jan 18 '23 22:01 LukaszRozmej

@xas Thank you much for the idea. Closing in favor of #5314.

rubo avatar Feb 20 '23 22:02 rubo