juno
juno copied to clipboard
Update `starknet_call` to use new storage primitives
Description
Updates the starknet_call JSON-RPC endpoint to use the new storage primitives introduced in Cairo 0.10.
Changes:
This also:
- Fixes tests that were supposed to halt execution being allowed to continue.
- Refactors log and error messages to be more descriptive.
- Adds some documentation to clarify concepts.
- Exports the error messages from the JSON-RPC 2.0 package so that they can be used here.
- Adds a
felt.SetStringshelper. - Positions the call to move away from the global logger to an injected one.
Types of changes
- Bugfix (non-breaking change which fixes an issue)
- Documentation Update
- Code style update (formatting, renaming)
- Refactoring (no functional changes, no api changes)
Testing
Requires testing: Yes
Did you write tests??: No
Documentation
If this requires a documentation update, did you add one? No
Codecov Report
Merging #409 (913f9b8) into main (c5cc557) will increase coverage by
0.53%. The diff coverage is94.93%.
@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 92.84% 93.37% +0.53%
==========================================
Files 67 68 +1
Lines 7350 7338 -12
==========================================
+ Hits 6824 6852 +28
+ Misses 519 478 -41
- Partials 7 8 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 93.37% <94.93%> (+0.53%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| internal/cairovm/vmrpc/vm.go | 83.33% <0.00%> (ø) |
|
| internal/cairovm/vmrpc/vm_grpc.pb.go | 100.00% <ø> (ø) |
|
| internal/juno/juno.go | 100.00% <ø> (ø) |
|
| internal/rpc/starknet/starknet.go | 0.00% <ø> (ø) |
|
| pkg/felt/helpers.go | 97.27% <76.92%> (-2.73%) |
:arrow_down: |
| internal/cairovm/vm.go | 100.00% <100.00%> (ø) |
|
| internal/cairovm/vmrpc/vm.pb.go | 100.00% <100.00%> (ø) |
|
| internal/validate/validate.go | 100.00% <100.00%> (ø) |
|
| pkg/jsonrpc/request.go | 100.00% <100.00%> (ø) |
|
| pkg/jsonrpc/server.go | 100.00% <100.00%> (ø) |
|
| ... and 4 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.