juno icon indicating copy to clipboard operation
juno copied to clipboard

[sync] solve error around starting block Number

Open stdevMac opened this issue 3 years ago • 1 comments

Resolves #361

Description

Solve the problem that exists around the initial block fetched.

Changes:

  • Set as default that the minimum block synced and the current block synced, both are the minimum between the block and the state processed.
  • Fix Syncing response on Sync

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Testing

Requires testing: No

Did you write tests??: No

stdevMac avatar Aug 18 '22 15:08 stdevMac

Codecov Report

Merging #362 (12a4303) into main (fcfe1e1) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          55       55           
  Lines        6464     6467    +3     
=======================================
+ Hits         6440     6443    +3     
  Misses         24       24           
Flag Coverage Δ
unittests 99.62% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/sync/utils.go 100.00% <ø> (ø)
internal/db/sync/manager.go 100.00% <100.00%> (ø)
internal/sync/sync.go 100.00% <100.00%> (ø)
pkg/felt/felt.go 100.00% <0.00%> (ø)
pkg/crypto/weierstrass/weierstrass.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 18 '22 18:08 codecov[bot]