juno
juno copied to clipboard
Fix RPC bugs
resolves #350, resolves #352
Description
Fix bugs on the RPC related to errors and params management.
Changes:
- Fix
starknet_getStorageAtparams order - Add custom error types:
NewUnexpectedError,NewNotImplementedError,NewInvalidStorageKey - Improve the error management on
getBlockByIdfunction - Check params on
starknet_call - Check
BlockIdis non-negative if is a number
Types of changes
- Bugfix (non-breaking change which fixes an issue)
Testing
Requires testing: Yes
Did you write tests??: No (Now we are testing these bugs by hand)
Documentation
If this requires a documentation update, did you add one? No
Codecov Report
Merging #360 (2650e85) into main (7996505) will decrease coverage by
0.00%. The diff coverage isn/a.
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 99.62% 99.62% -0.01%
==========================================
Files 55 55
Lines 6470 6467 -3
==========================================
- Hits 6446 6443 -3
Misses 24 24
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 99.62% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/crypto/weierstrass/weierstrass.go | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.