juno icon indicating copy to clipboard operation
juno copied to clipboard

Sync time improve

Open stdevMac opened this issue 1 year ago • 1 comments

Description

To perform a sync, we needed to execute one call to the API for each deployed contract.

After this PR gets merged, this call to the feeder is going to be performed in the collection of the State Diffs.

Changes:

  • Move fetching of Full Contract Definition to collectors
  • Improve feeder cadence

Types of changes

Leave only items that describe your changes, remove the rest. Remove this line too.

  • Refactoring (no functional changes, no api changes)

Testing

Requires testing: No

Did you write tests??: No

Documentation

If this requires a documentation update, did you add one? No

stdevMac avatar Aug 15 '22 22:08 stdevMac

Codecov Report

Merging #357 (123e42d) into main (ba47409) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   99.48%   99.62%   +0.13%     
==========================================
  Files          55       55              
  Lines        6457     6464       +7     
==========================================
+ Hits         6424     6440      +16     
+ Misses         33       24       -9     
Flag Coverage Δ
unittests 99.62% <100.00%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/metrics/prometheus/metrics.go 73.33% <ø> (+3.12%) :arrow_up:
internal/sync/apiCollection.go 100.00% <ø> (ø)
internal/sync/l1Collector.go 100.00% <ø> (ø)
internal/sync/sync.go 100.00% <ø> (ø)
internal/sync/utils.go 100.00% <ø> (ø)
pkg/feeder/feeder.go 100.00% <100.00%> (+1.72%) :arrow_up:
pkg/crypto/weierstrass/weierstrass.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 16 '22 13:08 codecov[bot]