juno
juno copied to clipboard
Python in docker
Closes #334
Description
Update the docker image
Changes:
- Install python dependencies inside docker image
- Add workflow for uploading docker image to docker hub
Types of changes
Leave only items that describe your changes, remove the rest. Remove this line too.
- Bugfix (non-breaking change which fixes an issue)
Testing
Requires testing: No
Did you write tests??: No
Documentation
If this requires a documentation update, did you add one? Yes
Codecov Report
Merging #345 (f992766) into main (ba47409) will increase coverage by
0.13%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 99.48% 99.62% +0.13%
==========================================
Files 55 55
Lines 6457 6466 +9
==========================================
+ Hits 6424 6442 +18
+ Misses 33 24 -9
Flag | Coverage Δ | |
---|---|---|
unittests | 99.62% <100.00%> (+0.13%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
internal/metrics/prometheus/metrics.go | 73.33% <ø> (+3.12%) |
:arrow_up: |
internal/sync/apiCollection.go | 100.00% <ø> (ø) |
|
internal/sync/l1Collector.go | 100.00% <ø> (ø) |
|
internal/sync/sync.go | 100.00% <ø> (ø) |
|
internal/sync/utils.go | 100.00% <ø> (ø) |
|
pkg/feeder/feeder.go | 100.00% <100.00%> (+1.72%) |
:arrow_up: |
pkg/felt/felt.go | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This is really neat! For the github action, should we use the well-supported docker/build-push-action
instead? I think we can pretty much copy-paste the workflow here.
I feel that using dedicated actions should increase the resilience of the CI and reduce the number of arbitrary run
command lines, but it might be too small of a detail to spend time improving.