juno icon indicating copy to clipboard operation
juno copied to clipboard

shutdown on error

Open jelilat opened this issue 3 years ago • 1 comments

Resolves https://github.com/NethermindEth/juno/issues/336

Description

If an error is caught in checkErrChs, we immediately exit with a log message. This PR is meant to allow it to exit cleanly without a trace

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

jelilat avatar Aug 10 '22 07:08 jelilat

Codecov Report

Merging #338 (c329831) into main (1543782) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #338   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        59           
  Lines         6737      6739    +2     
=========================================
+ Hits          6737      6739    +2     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/felt/felt.go 100.00% <0.00%> (ø)
pkg/crypto/weierstrass/weierstrass.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 15:08 codecov[bot]

closing because of #359

IronGauntlets avatar Aug 23 '22 21:08 IronGauntlets