juno
juno copied to clipboard
Remove --sync-trustless config param
Description
Juno panics if only --sync-enable
is provided. We can fix this by removing the need for the --sync-trustless
param.
Changes
- Remove the
--sync-trustless
config param. Instead, try to connect to an Ethereum node. If the connection fails for any reason, default to syncing with the feeder gateway. - Update documentation
Types of changes
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Documentation Update
Testing
Requires testing? No (no unit tests written for the main package at this time, see #301). This was manually tested.
Documentation
If this requires a documentation update, did you add one? Yes
Codecov Report
Merging #337 (3825d43) into main (fcfe1e1) will decrease coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 99.62% 99.62% -0.01%
==========================================
Files 55 55
Lines 6464 6461 -3
==========================================
- Hits 6440 6437 -3
Misses 24 24
Flag | Coverage Δ | |
---|---|---|
unittests | 99.62% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
internal/sync/sync.go | 100.00% <ø> (ø) |
|
pkg/crypto/weierstrass/weierstrass.go | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.