juno icon indicating copy to clipboard operation
juno copied to clipboard

Split out mdbx so RPC client doesn't have to depend on it

Open archseer opened this issue 2 years ago • 6 comments

We're not using the server code, but are instead using Juno as a RPC client. The client package depends on some internal bits which then pull in mdbx which introduces additional build constraints: it currently only builds via clang (https://github.com/NethermindEth/juno/issues/152).

archseer avatar Jul 01 '22 12:07 archseer

Hello @archseer could you please provide more details about what you are using? we will have soon a great improvement on the RPC server, which might be interesting for you

stdevMac avatar Jul 05 '22 10:07 stdevMac

We are only using the RPC client, not the RPC server. Our node will use Juno/Caigo to send transactions onto the network: https://github.com/smartcontractkit/chainlink-starknet/tree/develop/pkg/starknet

archseer avatar Jul 05 '22 10:07 archseer

So we don't need an server with an embedded database, just a straightforward RPC client. mdbx is adding additional build constraints to our build process which might be a problem for us to ship.

https://github.com/smartcontractkit/chainlink-starknet/issues/44

archseer avatar Jul 05 '22 10:07 archseer

Good, we will take a look at that and see how we can sort out those dependencies, and see if it is not solved on the new RPC implementation, in any case, we will solve it in the next couple of days, that works for you?

stdevMac avatar Jul 05 '22 10:07 stdevMac

No rush! Just wanted to raise the issue early enough while you're still working on the RPC package. I think it would make sense to split out the types and common parts, then have two packages that depend on that: one for the server and one for the client.

archseer avatar Jul 05 '22 10:07 archseer

When ready #313, this should be ready too

stdevMac avatar Sep 01 '22 14:09 stdevMac