juno icon indicating copy to clipboard operation
juno copied to clipboard

Replace the Goerli network with Sepolia in the test TestRpcBlockAdaption

Open stefanalfbo opened this issue 1 year ago • 3 comments
trafficstars

This includes adding a block and a signature json-file to the testdata directory for the Sepolia network.

This PR is fixing the issue #1796.

stefanalfbo avatar Apr 05 '24 19:04 stefanalfbo

@stefanalfbo Great work, thank you for contributing to juno! ❤️

Please note that previous PR (#1768) has spread rpc handlers tests into several file. Kindly request to rebase your work onto current main and push again.

Thank you 🙏

pnowosie avatar Apr 25 '24 11:04 pnowosie

This one has been rebased on current main now @pnowosie.

stefanalfbo avatar Apr 25 '24 20:04 stefanalfbo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.18%. Comparing base (a923c90) to head (4c9e192).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
+ Coverage   75.11%   75.18%   +0.06%     
==========================================
  Files          96       96              
  Lines        8183     8183              
==========================================
+ Hits         6147     6152       +5     
+ Misses       1513     1509       -4     
+ Partials      523      522       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 28 '24 15:04 codecov[bot]

This PR will be merge to main as a part of #1861

pnowosie avatar May 08 '24 13:05 pnowosie