juno icon indicating copy to clipboard operation
juno copied to clipboard

Replace Goerli2 network with Sepolia in the test TestEvents

Open stefanalfbo opened this issue 1 year ago • 5 comments

This PR is fixing the issue #1790, includes making a copy of the necessary testdata used from the goerli2 directory to a new sepolia directory.

stefanalfbo avatar Apr 03 '24 19:04 stefanalfbo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.04%. Comparing base (619fffd) to head (e65be28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
+ Coverage   74.92%   75.04%   +0.12%     
==========================================
  Files          96       96              
  Lines        8183     8183              
==========================================
+ Hits         6131     6141      +10     
+ Misses       1523     1517       -6     
+ Partials      529      525       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 04 '24 07:04 codecov[bot]

The test data should come from the Sepolia network, not the Goerli network. See PR https://github.com/NethermindEth/juno/pull/1793 for more details

rianhughes avatar Apr 04 '24 07:04 rianhughes

Thank you, yes hopefully it will be pretty straight forward to update the TestEvents function in blockchain_test.go now.

stefanalfbo avatar Apr 05 '24 17:04 stefanalfbo

@stefanalfbo Great work, thank you for contributing to juno! ❤️

Please note that previous PR (#1768) has spread rpc handlers tests into several file. Kindly request to rebase your work onto current main and push again.

Thank you 🙏

pnowosie avatar Apr 25 '24 11:04 pnowosie

Thanks @pnowosie, it should now be rebased on main.

stefanalfbo avatar Apr 25 '24 19:04 stefanalfbo