juno icon indicating copy to clipboard operation
juno copied to clipboard

#1184 changes for automatically generating RPC

Open ssonthal opened this issue 1 year ago • 2 comments

ssonthal avatar Mar 11 '24 19:03 ssonthal

#1184

ssonthal avatar Mar 11 '24 19:03 ssonthal

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.14%. Comparing base (ccba957) to head (0fc7152).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
- Coverage   72.17%   72.14%   -0.04%     
==========================================
  Files          90       90              
  Lines        9721     9721              
==========================================
- Hits         7016     7013       -3     
- Misses       2182     2183       +1     
- Partials      523      525       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 02 '24 04:04 codecov[bot]

Hi @shubham-sonthalia 👋

Thank you very much for your contribution. It is very appreciated, but I'll have to close your PR for the following reasons:

  • https://github.com/NethermindEth/juno/pull/1857 introduces a lot of refactoring to the docs, including migrating from Docusaurus 2 to 3, and it won't be compatible with your PR
  • Your integration is incomplete. You should add the snippet to the plugins config (or create it), not replace the preset config.
  • The PR does not modify the package.json and package-lock.json files to add the installation for @metamask/docusaurus-openrpc

I want to quickly clean up the docs for the next release, so I'll tackle #1184 in #1857. However, when you make docs contributions in the future, tag me, and I'll walk you through completing it 😄

LordGhostX avatar May 20 '24 02:05 LordGhostX