dotnet-libp2p icon indicating copy to clipboard operation
dotnet-libp2p copied to clipboard

Issue#63 - Adding Nullable checks

Open ssonthal opened this issue 1 year ago • 3 comments

Screenshot 2024-02-23 at 11 04 28 AM

ssonthal avatar Feb 23 '24 05:02 ssonthal

Hi @rubo @flcl42 kindly review the PR for resolving the build warnings for nullable references.

ssonthal avatar Feb 23 '24 05:02 ssonthal

Hey @flcl42, for the solution level, I was previously getting 60 warnings. I have reduced them down to 25 now. But now, I am not sure about the null checks because they are causing some other issues when adding nullables there.

ssonthal avatar Feb 23 '24 18:02 ssonthal

Hey @flcl42, for the solution level, I was previously getting 60 warnings. I have reduced them down to 25 now. But now, I am not sure about the null checks because they are causing some other issues when adding nullables there.

You can propose solution and let me help you with comments

flcl42 avatar Feb 26 '24 15:02 flcl42