cairo-vm-go icon indicating copy to clipboard operation
cairo-vm-go copied to clipboard

Published 20 hours ago • verified publisher icon NethermindEth

Create a structure for Scope value types instead of using interface #347

Open fmmesen opened this issue 1 year ago • 4 comments

All unit tests have been run successfully after changes.

fmmesen avatar Apr 24 '24 06:04 fmmesen

@MaksymMalicki Already made the changes even for new branches. All tests are running. Screenshot 2024-04-25 at 05 41 07

fmmesen avatar Apr 25 '24 11:04 fmmesen

One thing is before pushing to this branch, you can run golangci-lint run and gofmt -w . to fix the linter issues. Thanks!

MaksymMalicki avatar Apr 25 '24 17:04 MaksymMalicki

Lgtm for know 😁 @cicr99 can you take a look?

MaksymMalicki avatar Apr 26 '24 09:04 MaksymMalicki

@fmmesen any update on this?

TAdev0 avatar May 15 '24 22:05 TAdev0

Thanks for your work @fmmesen . Unfortunately, this solution is no longer applicable for the problem we want to solve, as described here, so I'll be closing this PR.

cicr99 avatar May 28 '24 09:05 cicr99