cairo-vm-go icon indicating copy to clipboard operation
cairo-vm-go copied to clipboard

Published 20 hours ago • verified publisher icon NethermindEth

Cairo0 unsafe keccak hint

Open MaksymMalicki opened this issue 1 year ago • 2 comments

MaksymMalicki avatar Apr 21 '24 19:04 MaksymMalicki

Currently the NewLegacyKeccak256() from the https://pkg.go.dev/golang.org/x/crypto/sha3 is used, which is also used in the go-ethereum crypto package. Alternatively, we could use this package, which is 10x faster on the benchmarks, than the package used in lambdaclass golang-vm.

MaksymMalicki avatar May 13 '24 17:05 MaksymMalicki

@cicr99 @rodrigo-pino what do you think? Why not using a faster implementation ?

TAdev0 avatar May 22 '24 15:05 TAdev0

Actually after some research, the benchmarks aren't that better than the official goland lib for sha3 and it's not maintaned, so I think we should stick to what we are using currently

MaksymMalicki avatar Jun 06 '24 10:06 MaksymMalicki