Forta-Agents icon indicating copy to clipboard operation
Forta-Agents copied to clipboard

Reentrancy bot: Context update

Open RCantu92 opened this issue 2 years ago • 0 comments

Reentrancy Counter bot

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ ] New Bot
  • [ ] Fix a bot error
  • [x] Update a bot logic/test/documentation
  • [ ] Code style update (formatting, renaming)
  • [ ] Other (please describe):

New Bot PR readiness

  • [x] npm install command works (i.e. package-lock is updated properly)
  • [x] The name and description fields of package.json describe the bot properly
  • [x] All the libraries listed in package.json are being used
  • [x] All the development libraries are in devDependencies section of package.json
  • [x] The bot README is updated
  • [x] The bot README sufficiently describes what the bot does
  • [x] All the alerts that the bot emits are listed in the README
  • [ ] The txn/block examples listed in the README generate the expected findings
  • [x] Code is easy to follow and/or properly commented
  • [x] Bot contains tests
  • [x] All tests pass when running npm test
  • [x] Tests are not making real network calls (i.e. network interaction is properly mocked)
  • [x] Tests cover all the paths (i.e. negative & positive test cases)
  • [x] When the tests complete, no warning/errors are shown
  • [x] npm start works without errors when executed using a jsonRpcUrl for each of the networks specified in the README
  • [x] The networks specified in the README and the networks are listed in the package.json are the same
  • [x] The code does what the README describes
  • [ ] Network calls are properly being cached (if duplicated calls can occur)
  • [ ] A performance review has been done (e.g. Promise.all is used whenever possible)
  • [x] The findings fields are filled out correctly
  • [ ] Findings protocol is specified (if the bot is for a specific one)
  • [x] metadata of the findings contains all the information needed.
  • [x] The SDK methods are being used appropriately (e.g. filterLog, filterFunction, getEthersProvider)
  • [ ] ABIs match the contracts used / args used from LogDescriptions exists in the ABIs
  • [x] The bot follows Forta recommended best practices
  • [x] Bot can recover from failed error calls when they can fail (e.g. errors are being caught on calls that can fail)
  • [x] repository is added in the package.json

Comments (optional)

If there is some useful information or important note for reviewing/understanding this bot please describe it here.

RCantu92 avatar Oct 24 '23 02:10 RCantu92