Forta-Agents
Forta-Agents copied to clipboard
Reentrancy bot: Context update
Reentrancy Counter bot
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
- [ ] New Bot
- [ ] Fix a bot error
- [x] Update a bot logic/test/documentation
- [ ] Code style update (formatting, renaming)
- [ ] Other (please describe):
New Bot PR readiness
- [x]
npm installcommand works (i.e. package-lock is updated properly) - [x] The
nameanddescriptionfields ofpackage.jsondescribe the bot properly - [x] All the libraries listed in
package.jsonare being used - [x] All the development libraries are in
devDependenciessection ofpackage.json - [x] The bot README is updated
- [x] The bot README sufficiently describes what the bot does
- [x] All the alerts that the bot emits are listed in the README
- [ ] The txn/block examples listed in the README generate the expected findings
- [x] Code is easy to follow and/or properly commented
- [x] Bot contains tests
- [x] All tests pass when running
npm test - [x] Tests are not making real network calls (i.e. network interaction is properly mocked)
- [x] Tests cover all the paths (i.e. negative & positive test cases)
- [x] When the tests complete, no warning/errors are shown
- [x]
npm startworks without errors when executed using a jsonRpcUrl for each of the networks specified in the README - [x] The networks specified in the README and the networks are listed in the
package.jsonare the same - [x] The code does what the README describes
- [ ] Network calls are properly being cached (if duplicated calls can occur)
- [ ] A performance review has been done (e.g.
Promise.allis used whenever possible) - [x] The findings fields are filled out correctly
- [ ] Findings
protocolis specified (if the bot is for a specific one) - [x]
metadataof the findings contains all the information needed. - [x] The SDK methods are being used appropriately (e.g.
filterLog,filterFunction,getEthersProvider) - [ ]
ABIs match the contracts used /argsused fromLogDescriptionsexists in theABIs - [x] The bot follows Forta recommended best practices
- [x] Bot can recover from failed error calls when they can fail (e.g. errors are being caught on calls that can fail)
- [x]
repositoryis added in thepackage.json
Comments (optional)
If there is some useful information or important note for reviewing/understanding this bot please describe it here.