vizceral icon indicating copy to clipboard operation
vizceral copied to clipboard

Particles flickering

Open baransu opened this issue 7 years ago • 8 comments

When we have bi-directional connection between two nodes and one of them is another color (warrning, error) there is flickering between layers. There is probably the same thing with normal particles but because of the same neutral color it's not visible.

This may happend because of texture overlay on the same axis.

Here is an example: https://youtu.be/-AvscsVSyck

baransu avatar Apr 08 '17 06:04 baransu

Here is example data when this happen with Vizceral 4.4.0: https://gist.github.com/Baransu/a6a77996e758c523e2af0875a9aed9c9

baransu avatar Apr 08 '17 08:04 baransu

Yep, looks exactly like because the connections are on the same axis. We don't have any bi-directional connections that have traffic at the same time, so that's why we've never run into this.

https://github.com/Netflix/vizceral/blob/master/src/base/connectionView.js#L222 should probably have some logic to determine directionality and change depth(z) based on that.

One easy (hacky?) way to do it would be to use alphabetical ordering of name to determine how to set z (if source.name > target.name: z += 1), so that if the connection runs the other way, it will have a different depth.

Try that and see how it feels. If you think of a better way, happy for suggestions too.

jrsquared avatar Apr 09 '17 16:04 jrsquared

Changing depth based on alphabetical ordering is not that bad. I was thinking how we can use .isEntryNode() for that but this would only apply for connection to/from entryNode and we can have bi-directional connection between other nodes to. I would go with alphabetical ordering.

baransu avatar Apr 09 '17 16:04 baransu

I'm surprised but this doesn't fix flickering 🤔

baransu avatar Apr 09 '17 17:04 baransu

Sorry I dropped this one. I honestly thought that would fix it. If you still are having this issue, I can take a look sometime this week.

jrsquared avatar May 07 '17 00:05 jrsquared

@Baransu out of curiosity, did you run into and issue where things overlap and keep on loading (only with bidir traffic, removing the second direction fixes the problem)?

image

remiphilippe avatar Jun 18 '17 22:06 remiphilippe

You have region loading because you don't have entryNode specified probablly.

I had flickering with bidir connection when one of them was in different color which multiplies flickering effect because you see how layers are overlaping each other.

baransu avatar Jun 19 '17 06:06 baransu

Good catch thanks, I typed entryPoint instead of entryNode, still shows loading but there could be another error. I see the same flickering with color though not major in my case.

image

remiphilippe avatar Jun 20 '17 03:06 remiphilippe