security_monkey icon indicating copy to clipboard operation
security_monkey copied to clipboard

Hardcoded reference to Riot Games

Open blazingkin opened this issue 5 years ago • 4 comments

https://github.com/Netflix/security_monkey/blob/4d198ad29b2f7a828ce130d222c6e76e71b9ce11/scripts/secmonkey_auto_install.sh#L606

Seeing as this is a netflix product, the only hardcoding I would expect would be for Netflix.

Either way. This should probably be configurable

blazingkin avatar Aug 22 '19 18:08 blazingkin

That should be configurable. Please feel free to submit a PR to fix it.

mikegrima avatar Aug 22 '19 18:08 mikegrima

That should be configurable. Please feel free to submit a PR to fix it.

@mikegrima Can I create a PR for this? I think we can make it configurable by passing one extra argument like -o to mention the company name similarly what is being done for $website using positional parameter -w|--website . If the value is not set we can set it to some default value during the creation of ssl certificate. Let me know if my understanding is correct.

Niladri24dutta avatar Sep 18 '19 19:09 Niladri24dutta

@mikegrima here is the code which I am referring to https://github.com/Netflix/security_monkey/blob/4d198ad29b2f7a828ce130d222c6e76e71b9ce11/scripts/secmonkey_auto_install.sh#L167

Niladri24dutta avatar Sep 18 '19 19:09 Niladri24dutta

https://github.com/Netflix/security_monkey/pull/1232 👍🏻

sudo-ryan avatar Nov 28 '19 17:11 sudo-ryan