security_monkey icon indicating copy to clipboard operation
security_monkey copied to clipboard

ECS deploy

Open tabletcorry opened this issue 6 years ago • 7 comments

Basically, I tease the existing docker-compose file into three parts, for the major services that need to run in production. In order to function, the env files need to specify all the required variables in the new yaml files. I will document this.

This isn't perfect. An alternative solution would be to build the component compose files "on-the-fly" by parsing the base compose YAML. That may be the evolution of this change, but I wanted to prove out the basic ECS deployment.

Comments very welcome. I don't think this is merge-worth just yet, so I am interested in thoughts from the SM maintainers.

Changes:

  • Add individual docker compose files for ECS Compose tooling
  • Add script to deploy code to ECS
  • Make all docker init scripts exit on failure (to prevent zombie containers)
  • More env vars!

Todo:

  • [ ] Document new vars required
  • [ ] Add scripts to create ECS services

tabletcorry avatar May 02 '18 16:05 tabletcorry

Coverage Status

Coverage decreased (-0.007%) to 72.427% when pulling 4a6408035f44c3a588d03456da6472db276dc4dd on tabletcorry:ecs_deploy into adfe60674df22fb52d51d9794820009dfdf6c20f on Netflix:develop.

coveralls avatar May 02 '18 17:05 coveralls

Will be very interested in the docs.

mikegrima avatar May 11 '18 16:05 mikegrima

I'm definitely looking into an ECS Fargate deployment. Any chance for further progress on this PR?

badllama avatar Jan 11 '19 00:01 badllama

I have Security Monkey running on ECS in prod based on this PR so I'll have a dig tomorrow and see if I made any major changes

ollytheninja avatar Jan 16 '19 06:01 ollytheninja

I never pursued the Fargate changes @badllama, as the ECS deployment was functional and cheaper.

@ollytheninja 🎉

tabletcorry avatar Jan 16 '19 16:01 tabletcorry

The only missing item is a script to create the ECS services/cluster. But I don't have the time to create that now.

@mikegrima I am fine with this being merged now, especially since it worked for @ollytheninja. But I leave it up to you.

tabletcorry avatar Jan 16 '19 16:01 tabletcorry

Can you do me a favor and rebase it with the latest develop?

mikegrima avatar Jan 16 '19 17:01 mikegrima