metaflow icon indicating copy to clipboard operation
metaflow copied to clipboard

[WIP] Add params to connect to zipkin tracing platform

Open darinyu opened this issue 1 year ago • 5 comments

Tested running workflow using the following command

METAFLOW_ZIPKIN_ENDPOINT="{ENDPOINT_HERE}" METAFLOW_TRACING_URL_TEMPLATE="{END_POINT_HERE}/{trace_id}" python workflow.py run

Console result looks like the folloinwg:

2023-11-13 20:36:10.220 Done! See the run in the UI at http://url/HelloFlow/10180
2023-11-13 20:36:10.220 Tracing URL is https://url/cab34611f479c138c9af2f97575dd56f

darinyu avatar Nov 13 '23 20:11 darinyu

Testing[553] @ 5ece011223a9d02bc518e68438874b9e030eb4fd

nflx-mf-bot avatar Nov 13 '23 20:11 nflx-mf-bot

QQ about the "METAFLOW_TRACING_URL_TEMPLATE": Do we have a universal template for each different endpoint? If so, would it be more reasonable to set this as a part of tracing/__init__ file?

wangchy27 avatar Nov 13 '23 20:11 wangchy27

Testing[553] @ 5ece011223a9d02bc518e68438874b9e030eb4fd

nflx-mf-bot avatar Nov 13 '23 21:11 nflx-mf-bot

QQ about the "METAFLOW_TRACING_URL_TEMPLATE": Do we have a universal template for each different endpoint? If so, would it be more reasonable to set this as a part of tracing/__init__ file?

We dont have one universal template for different endpoint. I saw that in Jaegar they use http://localhost:16686/trace/{trace-id}, and zipkin use url/request/{trace_id} so I decided to wirte a template with trace_id to be the variance and let user set up the rest of the template thru config.

darinyu avatar Nov 13 '23 21:11 darinyu

Testing[553] @ 5ece011223a9d02bc518e68438874b9e030eb4fd had 6 FAILUREs.

nflx-mf-bot avatar Nov 13 '23 22:11 nflx-mf-bot