Netflix
Fixes user names possibly having spaces
This fixes issue #100 . The issue mainly occurs because Metaflow passes through the systems user name directly to aws included in the job name.
Aws does not allow spaces in the batch job name so it fails with an Exception.
@Dudemullet Thanks for the PR. According to AWS documentation, Batch job names need to respect the following constraint first character must be alphanumeric, and up to 128 letters (uppercase and lowercase), numbers, hyphens, and underscores are allowed - Can you modify your implementation to take care of this constraint.
@savingoyal Of course will look into it.
It makes sense to look into all of these considerations, not just the spacing issue.
Sorry for the delay, was a very busy last month and am currently on vacation (no laptop) . But will look back into this on March 16
On 5 Mar 2020, at 2:14 AM, Savin [email protected] wrote:
@Dudemullet Any updates on this PR?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
@savingoyal Left the job_name length validation in the batch class and all the username validation sent to the batch_decorator.
As for the error messages I intentionally made them verbose but helpful but they're multiline so don't know if I got a little carried away with that.
hello all, this seem simple enough fix, could we proceed with planning to merge it. I'd be happy to help
