maestro icon indicating copy to clipboard operation
maestro copied to clipboard

Remove quartz dependency

Open varunu28 opened this issue 1 year ago • 6 comments

Pull Request type

  • [ ] Bugfix
  • [ ] Feature
  • [X] Refactoring (no functional changes, no api changes)
  • [X] Build related changes (Please run ./gradlew build --write-locks to refresh dependencies)
  • [ ] Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

This fixes #11 to remove the quartz dependency

  • Remove dependency on quartz
  • Refactor cron creation flow to use Cron instead of CronExpression
  • Impact of this change is that cron creation with a timezone is not possible but the execution time for the cron can be calculated using nextExecutionTime by providing a timezone.

varunu28 avatar Jul 25 '24 00:07 varunu28

@jun-he Please do a round of review whenever you get a chance? I am open to feedback on how can we support cron creation along with timezone during the creation operation.

varunu28 avatar Jul 25 '24 00:07 varunu28

@varunu28 thanks for the contribution. Will review it soon.

jun-he avatar Jul 27 '24 00:07 jun-he

@varunu28 can you rebase your change?

jun-he avatar Aug 02 '24 04:08 jun-he

@varunu28 can you rebase your change?

Done

varunu28 avatar Aug 02 '24 14:08 varunu28

@jun-he Bump on this for review. Thanks 👍

varunu28 avatar Aug 06 '24 01:08 varunu28

@varunu28 Will review it soon.

jun-he avatar Aug 08 '24 16:08 jun-he