remove joda time dependency from maestro-common
as it has been deprecated for a long time.
Hi @jun-he ,
I'd like to take on this task of removing the Joda-Time dependency from the maestro-common module.
Could you please assign this issue to me?
Additionally, I would like to clarify a few points:
Are there any specific parts of the codebase that have critical dependencies on Joda-Time, which I should be particularly careful about?
@jun-he
Please review the changes related to the removal of the Joda-Time dependency from the maestro-common module.
Thank you!
Found a similar issue in netflix-sel where there is an interdependency due to passing DateTimeZone in SEL.
Here is the relevant code snippet for the request body of the "Create a sample workflow" API:
{
"params": {
"foo": {
"expression": "new DateTime(1569018000000).withZone(DateTimeZone.forID('UTF')).monthOfYear().getAsText();",
"type": "STRING"
}
}
}
APIs are working fine, we can create an issue for the removal of joda time from netflix-sel
@pranaybattu thanks for the contribution! Yes, SEL also uses it and it needs some big changes to move away from it. Basically, we have to implement those SEL method using Java time libraries than Joda. So we can focus on remove it from other places in this issue. I will take a look the PR soon. Thanks.
I created a new issue for that: https://github.com/Netflix/maestro/issues/61
https://github.com/Netflix/maestro/pull/110