maestro icon indicating copy to clipboard operation
maestro copied to clipboard

remove joda time dependency from maestro-common

Open jun-he opened this issue 1 year ago • 6 comments

as it has been deprecated for a long time.

jun-he avatar Jul 23 '24 22:07 jun-he

Hi @jun-he ,

I'd like to take on this task of removing the Joda-Time dependency from the maestro-common module.

Could you please assign this issue to me?

Additionally, I would like to clarify a few points:

Are there any specific parts of the codebase that have critical dependencies on Joda-Time, which I should be particularly careful about?

pranaybattu avatar Jul 25 '24 12:07 pranaybattu

@jun-he

Please review the changes related to the removal of the Joda-Time dependency from the maestro-common module.

Thank you!

pranaybattu avatar Jul 25 '24 15:07 pranaybattu

Found a similar issue in netflix-sel where there is an interdependency due to passing DateTimeZone in SEL.

Here is the relevant code snippet for the request body of the "Create a sample workflow" API:

{
    "params": {
        "foo": {
            "expression": "new DateTime(1569018000000).withZone(DateTimeZone.forID('UTF')).monthOfYear().getAsText();",
            "type": "STRING"
        }
    }
}

pranaybattu avatar Jul 25 '24 15:07 pranaybattu

APIs are working fine, we can create an issue for the removal of joda time from netflix-sel

pranaybattu avatar Jul 25 '24 15:07 pranaybattu

@pranaybattu thanks for the contribution! Yes, SEL also uses it and it needs some big changes to move away from it. Basically, we have to implement those SEL method using Java time libraries than Joda. So we can focus on remove it from other places in this issue. I will take a look the PR soon. Thanks.

jun-he avatar Jul 26 '24 23:07 jun-he

I created a new issue for that: https://github.com/Netflix/maestro/issues/61

jun-he avatar Jul 26 '24 23:07 jun-he

https://github.com/Netflix/maestro/pull/110

jun-he avatar Jun 01 '25 05:06 jun-he