lemur icon indicating copy to clipboard operation
lemur copied to clipboard
verified publisher icon Netflix

CORS Update & New Config Params

Open joeinfor7685 opened this issue 3 years ago • 2 comments

Applications that have a separate front-end and back-end need to be able to update the CORS Origin, Allow Headers, and Allow Methods. We were running into various CORS errors on the front-end and need to be able to change these params.

The cors.init_app function has been updated with new params and the following config params have been added CORS_ORIGIN, CORS_ALLOW_HEADERS, and CORS_ALLOW_METHODS The admin docs have been updated as well.

joeinfor7685 avatar Feb 04 '22 20:02 joeinfor7685

Coverage Status

Coverage decreased (-0.009%) to 62.257% when pulling b30c55435baeb91930586dc604a7505130ee21a9 on infor-cloud:cors-update into 34d62073f9779795c575c9064aadb14da8780c5e on Netflix:master.

coveralls avatar Feb 04 '22 20:02 coveralls

@JoeMcRobot Thanks for contributing. I've left a comment, but otherwise it looks good.

charhate avatar Mar 30 '22 22:03 charhate

closing this PR due to inactivity, please feel free to open it as needed.

hosssha avatar Aug 23 '22 21:08 hosssha

Hi, this PR was overlooked and we are circling back. We have added the Authorization header to our branch, but I don't see an option to re-open. Please let us know if we should resubmit this PR. Thanks!

joeinfor7685 avatar Nov 03 '22 14:11 joeinfor7685