lemur icon indicating copy to clipboard operation
lemur copied to clipboard

Destination Plugin: Label restricted to 32 characters

Open sirferl opened this issue 4 years ago • 2 comments

The Database field label in table destinations is a char varying with 32 max length. We wanted to use longer labels. I changed the Max value to 50 with no adverse effects. How can we implement this in the code? regards

sirferl avatar Mar 03 '20 09:03 sirferl

The changes in code are here: https://github.com/Netflix/lemur/blob/master/lemur/destinations/models.py

Some instructions on how alembic can be handy to auto generate the migration: http://blog.code4hire.com/2017/06/setting-up-alembic-to-detect-the-column-length-change/

A previous example: https://github.com/Netflix/lemur/commit/13d46ae42e610ce4fb019105b6969e8d5e4da637

Addition the migration to the repo and applying it to the database:

git add lemur/lemur/migrations/versions/<some-number>_.py
lemur db migrate
lemur db upgrade

hosseinsh avatar Mar 10 '20 20:03 hosseinsh

ok, I will try that.

sirferl avatar Mar 11 '20 12:03 sirferl