go-expect test compatibility on windows

Open prietyc123 opened this issue 5 years ago • 4 comments

This pr fixes go-expect test compatibility on windows by replacing https://github.com/kr/pty with https://github.com/creack/pty and adding some dependencies.

Fixes #10

Mar 31 '20 09:03 prietyc123

Hi @prietyc123, thanks for this PR. Can you get the travis job for windows working?

Mar 31 '20 16:03 hinshun

Hi @prietyc123, thanks for this PR.

So this pr will basically executes the tests on windows successfully where go-expect package is used. It replaces https://github.com/kr/pty with https://github.com/creack/pty.

Can you get the travis job for windows working?

I will try to make it work for windows. Can I do it in separate pr once it get merged?

Mar 31 '20 16:03 prietyc123

Since this PR's goal is to execute tests on windows successfully, I would like it working on travis (for windows) in the same PR.

Mar 31 '20 17:03 hinshun

Any news on this?

Apr 04 '22 11:04 berlin4apk